Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To access a value by position, use ser.iloc[pos] #880

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

quant12345
Copy link
Contributor

@quant12345 quant12345 commented Oct 4, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR removes the warnings: FutureWarning:

Series.__setitem__ treating keys as positions is deprecated. In a future version, integer keys will always be treated as labels (consistent with DataFrame behavior). To set a value by position, use ser.iloc[pos] = value

tests to check:

pytest tests/test_feature_aggregate.py::test_aggregate_region_with_negative_weights[None]
pytest tests/test_feature_aggregate.py::test_aggregate_region_with_negative_weights[datetime]
pytest tests/test_io.py::test_load_meta_exclude

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.0%. Comparing base (ddbb88e) to head (2fd1cc5).
Report is 32 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #880   +/-   ##
=====================================
  Coverage   95.0%   95.0%           
=====================================
  Files         64      64           
  Lines       6134    6216   +82     
=====================================
+ Hits        5828    5910   +82     
  Misses       306     306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One minor suggestion for more useful release notes.

RELEASE_NOTES.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@danielhuppmann danielhuppmann merged commit 735c243 into IAMconsortium:main Oct 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants