Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_netcdf #898

Closed
wants to merge 49 commits into from
Closed

Add to_netcdf #898

wants to merge 49 commits into from

Conversation

LinhHo
Copy link
Contributor

@LinhHo LinhHo commented Dec 17, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Add the function to_netcdf to convert from :class:IamDataFrame to xarray Dataset, ready to be saved as a netCDF file.

Linh Ho and others added 30 commits July 12, 2024 13:50
add function read_agg_netcdf
633abce
Add to function read_agg_netcdf to read year-based and timeseries data
92b060f
Add meta indicators
09bf89d
Add logger warning for eliminated variables
192c1e8
@LinhHo
Add test file for read_netcdf function
7404b04
Add test netcdf not complete
ac4cbde
@LinhHo
Change file test to basic test_df from pyam
b973251
Add test_io for netcdf
b24f1f4
Read variables with exact NETCDF_IDX or raise Error
da210a1
@LinhHo @danielhuppmann
Update pyam/core.py
4d5c637 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/core.py
dfe55ee 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update tests/test_io.py
d288817 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Update pyam.netcdf
c1773e8
Update test netcdf
1f66256
Add except dependency xarray
074c1f8
@LinhHo @danielhuppmann
Update pyam/netcdf.py
cd43fac 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
6aee9e8 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
df13984 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Update concat method
8913733
Add documentation netcdf
ec6efdf
Adjust concatenate method
69a6bdd
Update test
5bf88db
@LinhHo @danielhuppmann
Update pyam/netcdf.py
a3f4c02 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
02401ef 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
2cff707 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
b764375 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
aee7245 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Update documentation
c6a3b9a
Clean up renaming code
4f50369
Fix nan test_it_netcdf
71eb7c3
LinhHo and others added 19 commits December 13, 2024 12:06
@LinhHo @danielhuppmann
Fix reading nan from xarray
6b48c27 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update tests/test_io.py
b84b4c4 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
447e9a9 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@LinhHo @danielhuppmann
Update pyam/netcdf.py
71b9f87 
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Update test and information netcdf
3be19e0
Update read_netcdf
1ae4219
Update read_netcdf
8e4eb7d
Update read_netcdf
f47d470
@danielhuppmann
Update lock file
bb6d9cc
@danielhuppmann
Fix release notes
5eb32ea
@LinhHo
Merge pull request #1 from danielhuppmann/netcdf-lock
c1375c3 
Netcdf lock
Update conflicting lines
e2e8c9c
Update conflicting lines
7cbf498
@LinhHo
Merge branch 'main' into netcdf
958a569
@LinhHo
Update poetry.lock
1ba89c1
@danielhuppmann
Update lock file
7e62749
@danielhuppmann
Make ruff
7b147b9
@danielhuppmann
Update expected plots using matplotib 3.9.4
6b73a54
Add to_netcdf
6a7c05f
@LinhHo
Copy link
Contributor Author

LinhHo commented Dec 17, 2024

@danielhuppmann Hello Daniel, I've just added the function to_netcdf and modified the test_io_netcdf accordingly. Would you mind having a look please?
I assume the documentation and the author list should be the same. I will update the release note after your confirmation.
Many thanks!

@danielhuppmann danielhuppmann mentioned this pull request Dec 18, 2024
Merged
3 tasks
@danielhuppmann
Copy link
Member

Closing in favor of #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinhHo @danielhuppmann