-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #901
Support Python 3.13 #901
Conversation
3fd7760
to
f3db046
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
======================================
Coverage 95.0% 95.0%
======================================
Files 64 66 +2
Lines 6134 6387 +253
======================================
+ Hits 5828 6074 +246
- Misses 306 313 +7 ☔ View full report in Codecov by Sentry. |
I can't re-run just the For the legacy test, it failed with this message:
I'm not sure how to handle this. The legacy test always runs with 3.10, but the install step still seems to check the whole version range, which has become incompatible with the bump to Python 3.13. One way around this might be to bump the legacy numpy version used, but that seems to defeat the purpose of the legacy test. EDIT: I only needed to bump the legacy numpy version from 1.26.0 to 1.26.2, which is acceptable, I hope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! The badge in the docs is not updated by a PR, but I'll do that in a separate PR on the netcdf docs that I'm working on right now.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Please confirm that this PR has done the following:
Description of PR
Having just released v0.9.8 of ixmp4, which support Python 3.13, this PR adds support for Python 3.13 to pyam. I adapted the Python badge, some workflow files, the
pyproject.toml
and the lock file, but please check I haven't forgotten anything.Please also note that I haven't trialed the PR locally, so if more dependencies don't support Python 3.13 yet, it might still fail.