Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rb-sys to 0.9.102 for ruby 3.4 compatibility #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

casperisfine
Copy link

@casperisfine casperisfine commented Sep 6, 2024

Otherwise it fails with:

LoadError: /tmp/bundle/ruby/3.4.0+0/gems/tiktoken_ruby-0.0.8/lib/tiktoken_ruby/tiktoken_ruby.so:
undefined symbol: ruby_abi_version - ruby_abi_version (LoadError)

However compilation is now failing with:

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_1`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:366:57
    |
366 |             slice::from_raw_parts(h.ptr as *const u8, h.len as usize)
    |                                                         ^^^ unknown field
    |
    = note: available fields are: `ptr`, `aux`

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_1`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:954:19
    |
954 |                 h.len as usize
    |                   ^^^ unknown field
    |
    = note: available fields are: `ptr`, `aux`

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_2`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:996:44
    |
996 |     value.as_internal().as_ref().as_.embed.len
    |                                            ^^^ unknown field
    |
    = note: available field is: `ary`

For more information about this error, try `rustc --explain E0609`.

Which I don't know how to fix. @ianks could you lend me a hand here?

@casperisfine
Copy link
Author

Nevermind, the compilation failure was because I forgot to rebase my fork 🤦

Otherwise it fails with:

```
LoadError: /tmp/bundle/ruby/3.4.0+0/gems/tiktoken_ruby-0.0.8/lib/tiktoken_ruby/tiktoken_ruby.so:
undefined symbol: ruby_abi_version - ruby_abi_version (LoadError)
```
@casperisfine
Copy link
Author

Hum, seems like there's no version of rb-sys compatible with both 3.4 and 2.7?

@ianks
Copy link

ianks commented Sep 7, 2024

Hum, seems like there's no version of rb-sys compatible with both 3.4 and 2.7?

rb-sys is (painfully) compatible down to 2.6

I think this error is a bundler issue?

  	There are no versions of bundler (= 2.5.18) compatible with your Ruby & RubyGems
  	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225.

Anyway, @IAPark we should probably drop 2.7 support since it's EOL and rb-sys will

@ianks
Copy link

ianks commented Sep 7, 2024

@IAPark just saw you are looking for maintainership help. Happy to lend a hand here if you send inv ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants