Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
TypeScript gives us more control over the logic of setting up
crane
, such as better validation and error handling. The biggest reason is to properly utilize a Runners built-inhostedtoolcache
, which will automatically cache thecrane
binary across runs without the need for additional upload/downloads like the normalactions/cache
Action does. In addition to this, a much more thorough test suite is written for both the code and Action itself.While these changes don't make the biggest difference for a tool as small as
crane
, but we should still align to best practices when it comes to setting up runner tooling.v1
andv2
will be maintained for critical issues.