Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of the JsonObject for current measurement #4

Open
rafaellehmkuhl opened this issue Oct 26, 2017 · 4 comments
Open

Change name of the JsonObject for current measurement #4

rafaellehmkuhl opened this issue Oct 26, 2017 · 4 comments

Comments

@rafaellehmkuhl
Copy link
Member

@Williangalvani

The JsonObject that stores the averageCurrent value is called "value", which doesnt make the request very clear, and creates a "wall" for new "values".

Could we change it to something like "currentValue", "averageCurrent" or something else?

@Williangalvani
Copy link

should we just change it to currentPower instead? and assume a power factor of 1?

@rafaellehmkuhl
Copy link
Member Author

Didnt quite understand. On the 'currentPower' name, current stands for "instant in time right now" or for the eletrycal quantity?

@Williangalvani
Copy link

Williangalvani commented Oct 27, 2017 via email

@rafaellehmkuhl
Copy link
Member Author

I agree to pass power, its our goal indeed.
We use 220V as standart effective voltage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants