This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 156
Dialog when no packages to delete #1567
Labels
Milestone
Comments
Jakeeyturner
added
bug
Something isn't working
good first issue
Good for newcomers
hacktoberfest
labels
Oct 18, 2019
lquintai
pushed a commit
to lquintai/blockchain-vscode-extension
that referenced
this issue
Nov 12, 2019
…-Blockchain#1567) Signed-off-by: Leonor-Maria Quintais <leonor-maria@oc4444350811.ibm.com>
lquintai
pushed a commit
to lquintai/blockchain-vscode-extension
that referenced
this issue
Nov 13, 2019
…-Blockchain#1567) Signed-off-by: Leonor-Maria Quintais <leonor-maria@oc4444350811.ibm.com>
cazfletch
pushed a commit
that referenced
this issue
Nov 19, 2019
cazfletch
added a commit
that referenced
this issue
Nov 21, 2019
* Changed local wallet name displayed when trying to delete identity (closes #1509). (#1534) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Transaction peer targeting (close #1514) (#1530) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Ignore non-JSON files and search subdirectories (resolves #1523) (#1541) Signed-off-by: Simon Stone <sstone1@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fixed disconnect env on all panels (close #1549) (#1551) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix associating identities with nodes (#1548) Pass in a wallet registry entry rather than a wallet contributes to #1517 Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Bump Fabric Node.js SDK levels (resolves #1554) Signed-off-by: Simon Stone <sstone1@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * try to run npm audit until it passes (#1536) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix insiders unit tests (#1559) Update electron and modules versions Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Update gateway registries (#1537) Update gateway registries to use new file based registry contributes to #1517 Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Update add environment tutorial (#1560) Update now that the ca doesn't include the enroll id and secret closes #1550 Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Update environment registries (#1562) Update to make environment registries use the file based registry contributes to #1517 Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Build - npm steps as script (#1561) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Add in being able to show the stack trace (#1563) Added param to output log to show the stack trace closes #1553 Signed-off-by: Caroline Fletcher <caroline.fletcher@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Show MSPID when peer targeting (#1566) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Disable npm audit (#1571) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updated exported connection profile (#1573) Removed wallet property as it's not a valid property of a connection profile and is just used internally closes #1459 Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Update repositories (#1565) Make repositories use the file based registry closes #1517 Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix insiders unit tests (#1579) Fixed tests on insiders build Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix telemetry (#1580) Add back in step to set production flag Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Added tree item for empty panels (close #1564) (#1568) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix adding identity to local wallet (#1581) Updated to get the mspid's from the node files closes #1465 Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updated audit dependency (#1582) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * No longer allows user to delete local_fabric_wallet from command pallette (#1583) Signed-off-by: Akshat Shah <akshatshah@akshats-mbp.hursley.uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Changelog (#1585) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Version bump and build (#1587) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix publishing (#1588) Update to use existing package Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Version bump (#1590) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Enabling reading in and switching between smart contracts (#1570) Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Build - continue on stderr (#1572) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Associate multiple nodes \n Added functionality and tests to associate multiple nodes at once using checkbox (#1552) Signed-off-by: Akshat Shah <akshatshah@akshats-mbp.hursley.uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updating dependencies to devdependencies (#1594) Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updated mispelt override (#1598) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Created skeleton screen for creating a new transaction (#1592) Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Added tutorials for identities on local fabric ca (#1325) Signed-off-by: Akshat Shah <akshatshah@akshats-mbp.hursley.uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Temp fix for No path for wallet has been provided (close #1593) (#1597) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Audit fix (#1610) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * java functional tests - code and tests (#1511) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updated Java test runner dependency (#1611) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Changelog (#1613) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Version bump (#1616) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Generation of transaction template based on user selection (#1608) Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Add fabric performance report link to HomeView (#1625) Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * update perf link to match new target (#1632) Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Resolve 2 vulnerabilities with npm audit fix (#1650) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Build Docker image using code-server (contributes to #1494) (#1637) Signed-off-by: Simon Stone <sstone1@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Return and show error when no open packages to chose from (Closes #1567) (#1635) Signed-off-by: Leonor-Maria Quintais <leonor-maria@oc4444350811.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Fix azure version bump (#1638) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Add instructions for building Docker image (contributes to #1494) Signed-off-by: Simon Stone <sstone1@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Update fabric version in cucumber tests (#1659) Updated to 1.4.4 Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Audit fix (#1665) Signed-off-by: Jake Turner <jaketurner25@live.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Added functionality to allow API keys & url to be stored along with relevant tests (#1618) Signed-off-by: Akshat Shah <akshatshah@akshats-mbp.hursley.uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Add Kubernetes configuration and instructions (contributes to #1494) Signed-off-by: Simon Stone <sstone1@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Make mono repo lerna (#1652) * Create a mono repo Moved all the files Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Create a mono-repo Update azure files contributes to #741 Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Ask user to select which nodes should be imported from Ops Tool (#1651) Signed-off-by: Leonor Quintais <lquintai@uk.ibm.com> Signed-off-by: Caroline Fletcher <cazfletch@gmail.com> * Updated branch to master added all commits from master Signed-off-by: Caroline Fletcher <cazfletch@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
If I have no packages and I run the
Delete smart contract packages
command from the command palette, I'm still presented with the dialog box.Expected Behavior
When we try to get all packages from the
showSmartContractPackagesQuickPickBox
function, but none are returned, we should return/throw an error.Actual Behavior
I'm presented with a dialog box asking me which smart contract package I want to delete. However, there are no packages to choose from.
Possible Fix
Steps to Reproduce
Existing issues
Log File
Your Environment
The text was updated successfully, but these errors were encountered: