This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Submit transactions in the react view (attempt 2) #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin-hughes
force-pushed
the
submit-txn-2
branch
2 times, most recently
from
cf72a95
to
a16da14
Compare
| const stylePathOnDisk: any = vscode.Uri.file( | ||
| path.join(this._extensionPath, 'build', mainStyle) | ||
| ); | ||
| const styleUri: any = stylePathOnDisk.with({ scheme: 'vscode-resource' }); | ||
| const styleContents: any = fs.readFileSync(styleUri.path); |
There was a problem hiding this comment.
Can you change these any's to the appropriate types
| transactionArguments: templateText | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| public render(): any { | ||
| populateTransactionSelect(): any { |
There was a problem hiding this comment.
Can you change the any types please
erin-hughes
force-pushed
the
submit-txn-2
branch
from
a16da14
to
35e4919
Compare
Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
erin-hughes
force-pushed
the
submit-txn-2
branch
from
35e4919
to
8268ced
Compare
Jakeeyturner
approved these changes
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1486 and contributes to #1155
Signed-off-by: Erin Hughes Erin.Hughes@ibm.com