This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Suggest transaction_data folders in open workspaces when associating directories #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin-hughes
force-pushed
the
suggest-dirs-1855
branch
from
e7703d9
to
dec63fc
Compare
cazfletch
suggested changes
Feb 11, 2020
| @@ -65,7 +67,18 @@ export async function associateTransactionDataDirectory(chaincode?: Instantiated | |||
|
|
|||
| gateway = await FabricGatewayConnectionManager.instance().getGatewayRegistryEntry(); | |||
|
|
|||
| const quickPickItems: string[] = [UserInputUtil.BROWSE_LABEL]; | |||
| const quickPickItems: Array<{ label: string, description: string }> = []; | |||
There was a problem hiding this comment.
That should be of type IBlockchainQuickPickItem then you can put the path as the data even if you also have the path as the description too
erin-hughes
force-pushed
the
suggest-dirs-1855
branch
from
dec63fc
to
8769d61
Compare
cazfletch
suggested changes
Feb 12, 2020
| @@ -74,11 +88,12 @@ export async function associateTransactionDataDirectory(chaincode?: Instantiated | |||
| filters: undefined | |||
| }; | |||
|
|
|||
| const transactionDataPath: string = await UserInputUtil.browse(`Choose a directory to associate with ${chaincodeLabel}`, quickPickItems, openDialogOptions) as string; | |||
| if (!transactionDataPath) { | |||
| const chosenDirectory: string | { label: string, description: string } = await UserInputUtil.browseWithOptions(`Choose a directory to associate with ${chaincodeLabel}`, quickPickItems, openDialogOptions) as string | {label: string, description: string }; | |||
There was a problem hiding this comment.
the return type should be a string or a IBlockchainQuickPickItem
Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
erin-hughes
force-pushed
the
suggest-dirs-1855
branch
from
8769d61
to
52160d9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1855 and contributes to #1155
Signed-off-by: Erin Hughes Erin.Hughes@ibm.com