Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DEPLOY_CRIO_CONFIG
istrue
, bothimage-endpoint
andruntime-endpoint
are generated as hard coded values here. This PR is to make them optionally configurable. To configure it,daemonset.crioEndpoint
can now be set invalues.yaml
, which translates to theCRIO_ENDPOINT
environment variable in the daemonset.Found this useful on setups that have dockershim. The default is still set to
unix:///run/containerd/containerd.sock
, so this should be backwards compatible.