Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress soft error and remove dependency of pusher on operator #11

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

sunya-ch
Copy link
Member

@sunya-ch sunya-ch commented Apr 5, 2023

This PR suppresses fatal throw when there is an human error defined in benchmark CR including:

  • define benchmark with not-found operator
  • unequal number of values to labels in conjunction case (with ; delimiter)

Related to the first common error when try deploying basic job spec, this PR also includes the code to deploy NoneOperator (some part pre-implemented in PR #10).

Also, this PR improves the CPE operator to export all performance metrics without requirement of COS or PushGateway , corresponding to the PR #9.

Example raw result on prometheus:
Screenshot 2023-04-05 at 18 26 40

Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com

…tion

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch sunya-ch merged commit 83c52f9 into IBM:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant