Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db2 authentication plugin using AWS Cognito #78

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Db2 authentication plugin using AWS Cognito #78

wants to merge 16 commits into from

Conversation

npanpaliya
Copy link

No description provided.

@npanpaliya npanpaliya requested a review from kdrodger as a code owner January 24, 2024 10:00
Nishidha Panpaliya and others added 9 commits January 24, 2024 21:28
@npanpaliya
Pushed AWS IAM plugin code
3c056bc 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Fixed for EC2 created from Amazon Linux 2
094b637 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Changed to build plugin with openssl 1.0.2
ab74f0a 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Added a master build script
63521e9 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Fixed plugin to make it work with lower version of json-c library ava…
7ccd43b 
…ilable on Amazon Linux 2

Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Minor fixes
fd3c9cd 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Some more minor fixes
507bfdc 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Some more cleanup
c00e274 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Removed unwanted code
b9dec8e 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Static code analysis fixes
dd68a94 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
kdrodger
kdrodger requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@kdrodger kdrodger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm told by Andrew and Irina that this still being reviewed and is not quite ready to go, not least of all because it contains a number of file headers which say that they are IBM confidential material, which of course would not belong here. I have been reassured by them that this was just a simple cut'n'paste error and that the contents are not actually confidential, but the PR will need to be cleaned up first anyway.

@npanpaliya
Copy link
Author

I'm told by Andrew and Irina that this still being reviewed and is not quite ready to go, not least of all because it contains a number of file headers which say that they are IBM confidential material, which of course would not belong here. I have been reassured by them that this was just a simple cut'n'paste error and that the contents are not actually confidential, but the PR will need to be cleaned up first anyway.

Yes, I'm correcting these and these are copy/paste errors.

@npanpaliya
Addressed Review comments
9d4ddb6 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Copy link
Author

@kdrodger @memmertoIBM - I've corrected the copyright info in all the source files. Also addressed the other comments regarding AWS libraries/version and README update.
Thank you for the review and please let me know if you've further comments.

@npanpaliya
Copy link
Author

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

@npanpaliya
Some more changes with copyright info
368b78c 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Copy link
Author

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

This issue is fixed too.

@kdrodger @memmertoIBM - Request you to review this PR.

@npanpaliya
Fixed issue with openssl and json_c version detection and macro setting
1da774e 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Cleanup of unwanted stuff
e253889 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Cleanup
9b8b93a 
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@kdrodger
Copy link
Member

kdrodger commented Apr 2, 2024

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

@npanpaliya
Copy link
Author

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

I'm no more part of this project. Please reach out to Andrew Hilden at IBM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdrodger kdrodger kdrodger requested changes

@memmertoIBM memmertoIBM memmertoIBM approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npanpaliya @kdrodger @memmertoIBM