Include reviewer feedback

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
IBM · Dec 4, 2023 · 2adfcc5 · 2adfcc5
1 parent e76f5f0
commit 2adfcc5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/.project b/.project
diff --git a/Scanners/README.md b/Scanners/README.md
@@ -7,15 +7,15 @@ Samples are supposed to follow the same structure. The custom dependency scanner
 
 * Clone the IBM/DBB repository into IDZ/Eclipse.
 * Import the scanner implementation as a JAVA project
-* Download the `<DBB-HOME>/lib/dbb.core_2.0.x.x.jar` package from your IBM DBB toolkit installation to your development environment 
-* Fix the build setup and of the scanner project.
+* Download the `<DBB-HOME>/lib/dbb.core_2.0.x.x.jar` package from your IBM DBB toolkit installation on z/OS Unix System Services to your development environment.
+* Fix the setup of the build path of the scanner project by adding the DBB core package as an External JAR under the Libraries configuration and remove any invalid references.
 * Implement changes in `runScan()` method of the scanner implementation that is extending `AbstractDependencyScanner`.
 * Create a `Run Configuration` for a Java Application for the scanner implementation (Note: The Run Configuration will not have a main method as we will not actually be using it to run the program. You might see some warnings.)
 * Execute the `Export Java > Runnable JAR file` action in IDZ/Eclipse, which will create the JAR file containing your custom scanner:
   * Select the previously created runner configuration
   * Select the export destination
   * In the Library handling section, select to `Copy required libraries into a sub-folder next to the generated JAR` option
-* Upload the generated JAR to z/OS Unix system services 
+* Copy the generated JAR to z/OS Unix system services as binary
 * Run the provided test script which each scanner implementation should provide. Details are included in the scanner project.
 
 ## Scanner implementations