Code Review's max acceptable return code shouldn't be hard-coded in the script, and should be < 4, not <= 2

[M-DLB]

In https://github.com/IBM/dbb/blob/main/Pipeline/RunIDZCodeReview/RunCodeReview.groovy#L115, the max acceptable return code shouldn't be hard-coded, it should externalized in the codeReview.properties file.

Also, it may be more accurate to set it to 3, as the Code Review's documentation states:

The tool can end with following return codes:                    
-  0: processing completed successfully                          
      there are no code review rule violations                   
      the generated code review output is valid                  
      the (optional) post-processing script executed successfully
-  1: processing completed successfully                          
      the most severe review violation is a recommendation (4)   
      the generated code review output is valid                  
      the (optional) post-processing script executed successfully
-  2: processing completed successfully                          
      the most severe review violation is a warning (8)          
      the generated code review output is valid                  
      the (optional) post-processing script executed successfully
-  3: processing completed successfully                          
      the most severe review violation is a severe violation (12)
      the generated code review output is valid                  
      the (optional) post-processing script executed successfully
-  4: processing did not complete for one or more files          
      the most severe review violation is a syntax error (15)    
      the generated code review output is valid, but excludes    
        results for the file(s) with a syntax error              
      the (optional) post-processing script executed successfully

[dennis-behm]

@M-DLB I think, this is now resolved ?

[M-DLB]

Indeed, resolved with #109