Added support for maxRC defined in property file or with CLI option #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dennis-behm Can you have a look please? |
|
@M-DLB Code looks fine. Can you please update the |
|
@dennis-behm I think it was already changed accordingly in this file https://github.com/IBM/dbb/pull/109/files#diff-6a506dec2a246c4779c878e043aade4ba820cd70b07cbaacaeeb32d87bf46b80 |
|
Sorry, I must have looked at your main branch ... |
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 6, 2022
…r with CLI option (IBM#109) Signed-off-by: John Nemec <john.nemec@ibm.com>
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 6, 2022
…r with CLI option (IBM#109) Signed-off-by: John Nemec <john.nemec@ibm.com>
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 6, 2022
…r with CLI option (IBM#109)
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 9, 2022
…r with CLI option (IBM#109) Signed-off-by: John Nemec <john.nemec@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to specify a maximum acceptable return code, which can be specified either in the property file, or through the CLI option (which takes precedence). If none of these options is used, a default acceptable RC is set to 3 (which is the highest value considered as acceptable by IDz v15 Code Review feature).