Enhance PackageBuildOutputs sample #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbyibm
reviewed
Feb 23, 2022
Comment on lines
+41
to
+43
| * -artifactory, | ||
| * --artifactoryPropertiesFile <propertyFile> Absolute path of a property file | ||
| * containing application specific |
There was a problem hiding this comment.
I'm wrong, or you are breaking the current behavior?
Can we keep the -prop,--propertyFile <propertyFile>with a deprecated notice?
There was a problem hiding this comment.
This is now implemented. Resolved
Comment on lines
337
to
344
| // read properties file | ||
| if (opts.properties){ | ||
| def propertiesFile = new File(opts.properties) | ||
| if (propertiesFile.exists()){ | ||
| propertiesFile.withInputStream { props.load(it) } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you add an else block to read the default property file you shipped in your PR ? (to avoid the assertion later and add backward compatibility)
There was a problem hiding this comment.
default packageBuildOutputs.properties file is tried to be read, if the --properties option was not passed.
jbyibm
approved these changes
Feb 28, 2022
This was referenced Feb 28, 2022
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 6, 2022
* externalize copymodes and allow packaging of additional build logs * Update readme * implements IBM#97 to mask artifactory password * Cli option -prop marked as deprecated Signed-off-by: John Nemec <john.nemec@ibm.com>
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 6, 2022
* externalize copymodes and allow packaging of additional build logs * Update readme * implements IBM#97 to mask artifactory password * Cli option -prop marked as deprecated Signed-off-by: John Nemec <john.nemec@ibm.com>
johnmnemec
pushed a commit
to johnmnemec/dbb
that referenced
this pull request
Sep 9, 2022
* externalize copymodes and allow packaging of additional build logs * Update readme * implements IBM#97 to mask artifactory password * Cli option -prop marked as deprecated Signed-off-by: John Nemec <john.nemec@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement of the current version of the PackageBuildOutputs. The changes propose to
--includeLogsoption or through the propertyincludeLogsthe property file (Comma-separated).deployTypeFilterin the property file.Please note, that the cli options have changed.
-prop/--propertyFilefor the Artifactory properties should be replaced with-artifactory/--artifactoryPropertiesFile. Using-prop/--propertyFileis marked as deprecated and might be removed in the next version.