Fix for the CodeReview script - Correct processing of the XML and CSV files #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep ASA characters Signed-off-by: Mathieu <mathieu.dalbin@fr.ibm.com>
dennis-behm
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR fixing issues with #136
The upgrade to the 1.1.3 toolkit introduced the capacity to remove ASA characters when saving spool output of JCLs into flat files on USS. However, this processing is not applicable to XML files and CSV files created by Code Review.
This fix disables the removing of ASA characters in spool outputs for the XML and CSV files generated by Code Review, making them available for additional processing.
Based on comments from Nikos from Handelsbanken, I've also changed the way the output files are saved when they DD names are available, even when the return code is higher than the expected Max RC.