Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Backend Scripts for pipeline implementations #179

Merged
merged 19 commits into from
Oct 26, 2023

Conversation

dennis-behm
Copy link
Member

Introducing a new category in the DBB community repository.

The contribution are templates to simplify the pipeline design and setup by providing a set of central services that are installed on Unix System Services that act as wrappers to the existing pipeline tasks such as clone, build, package and deploy.

The wrappers allow the DevX team to

  • separate the parameterisation of pipeline into application configuration and configuration of the pipeline tasks.
  • enforce naming conventions in the build and package stages

dennis-behm and others added 7 commits October 18, 2023 18:12
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Copy link
Collaborator

@M-DLB M-DLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
…nerate step

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm dennis-behm marked this pull request as ready for review October 25, 2023 12:53
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@rbsmall
Copy link
Contributor

rbsmall commented Oct 25, 2023

I have the following recommendations after reading through the primary readme:

  • Standardize usage of "Unix System Services" to "z/OS UNIX System Services"
  • Section 4.1 - change "Alhtough" to "Although"
  • Section 4.4 - In description of CLI parameter "-b", change "git branch turning into an segment" to "git branch turning into a segment" (replace "an" with "a")
  • Section 4.7 - In description of CLI parameter "-m", change "If not specified the deployment method" to "If not specified, the deployment method" (inserting a comma)
    • Same change for description of parameters "-p" and "-r"

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm
Copy link
Member Author

Thanks for the review @rbsmall. I have included your recommendations in 17b1137

@dennis-behm dennis-behm merged commit 94be084 into IBM:main Oct 26, 2023
1 check failed
@dennis-behm dennis-behm deleted the introduce_pipeline_templates branch October 30, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants