Packaging scripts update for zFS files #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links to IBM DevOps Acceleration Program Solution Page (IBM#186)
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
dennis-behm
reviewed
Nov 15, 2023
There was a problem hiding this comment.
@M-DLB I have a couple of comments on the code around improving readability of it.
We should run a pretty print on both scripts as well, because the indentation seems to be inconsistent.
| USSRecords.each{ USSRecord -> | ||
| ArrayList<ArrayList> outputs = [] | ||
| USSRecord.getAttribute("outputs").split(';').collectEntries { entry -> | ||
| outputs += entry.replaceAll('\\[|\\]', '').split(',') |
There was a problem hiding this comment.
Can we use the .add() method to add to the output list. Difficult to read this line.
There was a problem hiding this comment.
I've tried, I couldn't find the right syntax with add(). It's using the groovy style of coding, not the Java style.
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
dennis-behm
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
@M-DLB Thanks for the updates! And apologies, that I am late with my second review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for zFS files in the two packaging scripts (UCDCreateComponentVersion and PackageBuildOutputs).
It leverages a specific record type introduced in zAppBuild to support zFS outputs from build (currently used in CRB, zCEE3 and zCEE2 processing). This USS_RECORD is an AnyTypeRecord implementation.