Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute build parameters on updated branch naming conventions #200

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

dennis-behm
Copy link
Member

As indicated in #193, the pipeline backend scripts need to use shorter branch names.

This PR is refreshing the computation of the build conventions:

  • Feature branches are prefixed with an F.
  • Epic branches are prefixed with E.
  • Hotfix branches are prefixed with H.
  • Release Maintenance branches are prefixed with R.
branch name computed hlq
feature/42-new-mortgage-calculation PIPELINE.MORTGAGE.F42
feature/new-mortgage-calculation PIPELINE.MORTGAGE.FNMC
feature/newmortgagecalculation PIPELINE.MORTGAGE.FNEWMORT
release/rel-2.0.1 PIPELINE.MORTGAGE.R201
hotfix/rel-2.0.1/52-fix-mortgage-calculation PIPELINE.MORTGAGE.R201.H52
epic/ai-fraud-detection PIPELINE.MORTGAGE.EAFD
feature/ai-fraud-detection/54-introduce-ai-model-to-mortgage-calculation PIPELINE.MORTGAGE.EAFD.F54

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
… test log

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm
Copy link
Member Author

Had a chat with @M-DLB about it, who is proposing a more simpler layout for the branches.

Instead of multi segment, he is proposing

  • treating all Feature branches similar, and just prefix with an F.
  • treating all Hotfix branches similar, and just prefix with an H.

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm
Copy link
Member Author

@M-DLB

I have updated the scripts and followed your recommendations to name the feature branches.

The currently implemented layout is listed below. (*) identifies the changed names to the initial conventions that I proposed in the PR.

branch name computed hlq
feature/42-new-mortgage-calculation PIPELINE.MORTGAGE.F42
feature/new-mortgage-calculation PIPELINE.MORTGAGE.FNMC
feature/newmortgagecalculation PIPELINE.MORTGAGE.FNEWMORT
release/rel-2.0.1 PIPELINE.MORTGAGE.R201
hotfix/rel-2.0.1/52-fix-mortgage-calculation PIPELINE.MORTGAGE.H52 (*)
epic/ai-fraud-detection PIPELINE.MORTGAGE.EAFD
feature/ai-fraud-detection/54-introduce-ai-model-to-mortgage-calculation PIPELINE.MORTGAGE.F54 (*)

@dennis-behm
Copy link
Member Author

Please note that this PR improves the computation of the build parameter mainBuildBranch to set the origin branch correctly for feature and hot fix branches.

Copy link
Collaborator

@M-DLB M-DLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you

@dennis-behm dennis-behm merged commit f71c890 into IBM:main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants