Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Backend ScriptsdeleteWorkspace.sh script #202

Merged

Conversation

dennis-behm
Copy link
Member

This is adding a new script to the common backend scripts to allow pipelines to cleanup the workspace directory on Unix System Services.

For instance, when a feature branch pipeline is finished successfully, the files on Unix System Services are no longer needed and can be deleted.

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@M-DLB
Copy link
Collaborator

M-DLB commented Jan 15, 2024

@dennis-behm - As discussed orally, I think we should simplify the way repositories are cloned to USS, removing the branch name as part of the path. It would greatly simplify the management and the lifecycle of the branches, as repositories would be cloned under the temporary build folder, and this build folder would simply be removed at the end of the pipeline execution with the script you develop in this PR.
It means the processing would be much simpler as we wouldn't have to deal with this tree of potential empty folders, representing the different branches. Can you please update this script and the gitClone.sh to work that way?
Thank you!

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm
Copy link
Member Author

@M-DLB, please see commit 71657da for the script simplification. Let's treat the updated recommendation of the unique workspace id in a separate PR.

Copy link
Collaborator

@M-DLB M-DLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thank you

@dennis-behm dennis-behm merged commit 07c9499 into IBM:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants