-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computation of the baseline ref for release and epic branch workflow #227
Computation of the baseline ref for release and epic branch workflow #227
Conversation
…ntenance Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take care of these changes please? :)
"RELEASE" | "release" | "EPIC" | "epic") | ||
baselineRef=$(cat "${baselineReferenceFile}" | grep "^${mainBranchSegment}/${secondBranchSegment}" | awk -F "=" ' { print $2 }') | ||
;; | ||
"main" | "MAIN") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could translate to uppercase with tr
instead of checking different values.
@@ -209,7 +209,17 @@ computeBuildConfiguration() { | |||
|
|||
getBaselineReference() { | |||
|
|||
baselineRef=$(cat "${baselineReferenceFile}" | grep "^${mainBranchSegment}" | awk -F "=" ' { print $2 }') | |||
baselienRef="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here: baselienRef -> baselineRef
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
This is implementing the fix for #226 to retrieve the baseline reference from the
baselineReferences.config
according to the outlined naming conventions in https://ibm.github.io/z-devops-acceleration-program/docs/git-branching-model-for-mainframe-dev/#naming-conventions