Turn JDBC id and password into optional parameters #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
M-DLB
reviewed
Jun 3, 2024
| rc=8 | ||
| ERRMSG=$PGM": [ERROR] DBB database user is required. rc="$rc | ||
| echo $ERRMSG | ||
| echo $PGM": [WARNING] Db2 JDBC User not set. The usage of the Db2 DBB Metadatastore is recommended." |
There was a problem hiding this comment.
Could we rephrase the last sentence to:
For the DBB metadata database, the use of Db2 (z/OS or LUW) is recommended.
| rc=8 | ||
| ERRMSG=$PGM": [ERROR] DBB database password file is required. rc="$rc | ||
| echo $ERRMSG | ||
| echo $PGM": [WARNING] Db2 JDBC Password file not set. The usage of the Db2 DBB Metadatastore is recommended." |
There was a problem hiding this comment.
Could we rephrase the last sentence to:
For the DBB metadata database, the use of Db2 (z/OS or LUW) is recommended.
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
M-DLB
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementing #248 to allow the Common Backend Scripts to be used with the DBB FileMetadatastore.