Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunIDZCodeReview script uplifted to use JobExec instead of JCLExec #269

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

M-DLB
Copy link
Collaborator

@M-DLB M-DLB commented Aug 14, 2024

This PR changes the DBB API used to submit the IDz Code Review job, from JCLExec (deprecated in DBB 2.0.1) to JobExec.
Some reworking were also implemented to have consistent message printing.

Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
@M-DLB M-DLB requested a review from dennis-behm August 14, 2024 13:14
Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-DLB

Thanks for the enhancement. Can you please make a note in the README and the source of the script that this sample script required DBB 2.0.1?

I only have one additional comment below.

Pipeline/RunIDZCodeReview/RunCodeReview.groovy Outdated Show resolved Hide resolved
M-DLB and others added 3 commits August 23, 2024 14:29
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
@M-DLB M-DLB requested a review from dennis-behm August 23, 2024 12:54
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @M-DLB

@dennis-behm dennis-behm merged commit d3225e7 into IBM:main Aug 26, 2024
1 check failed
@M-DLB M-DLB deleted the feature/upliftIDZCodeReview branch August 29, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants