fix: remove File.GetName and add Join for convenience

Signed-off-by: Dr. Carsten Leue <carsten.leue@de.ibm.com>
IBM · Oct 11, 2023 · 1eefc28 · 1eefc28
1 parent af2915d
commit 1eefc28
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/context/readerioeither/file/tempfile.go b/context/readerioeither/file/tempfile.go
@@ -19,7 +19,6 @@ import (
 	"os"
 
 	RIOE "github.com/IBM/fp-go/context/readerioeither"
-	FL "github.com/IBM/fp-go/file"
 	F "github.com/IBM/fp-go/function"
 	IO "github.com/IBM/fp-go/io"
 	IOF "github.com/IBM/fp-go/io/file"
@@ -32,7 +31,7 @@ var (
 	// destroy handler
 	onReleaseTempFile = F.Flow4(
 		IOF.Close[*os.File],
-		IO.Map(FL.GetName),
+		IO.Map((*os.File).Name),
 		RIOE.FromIO[string],
 		RIOE.Chain(Remove),
 	)

diff --git a/file/getters.go b/file/getters.go
@@ -15,9 +15,11 @@
 
 package file
 
-import "os"
+import "path/filepath"
 
-// GetName is the getter for the `Name` property of [os.File]
-func GetName(f *os.File) string {
-	return f.Name()
+// Join appends a filename to a root path
+func Join(name string) func(root string) string {
+	return func(root string) string {
+		return filepath.Join(root, name)
+	}
 }
diff --git a/ioeither/file/tempfile.go b/ioeither/file/tempfile.go
@@ -18,7 +18,6 @@ package file
 import (
 	"os"
 
-	FL "github.com/IBM/fp-go/file"
 	F "github.com/IBM/fp-go/function"
 	IO "github.com/IBM/fp-go/io"
 	IOF "github.com/IBM/fp-go/io/file"
@@ -33,7 +32,7 @@ var (
 	// destroy handler
 	onReleaseTempFile = F.Flow4(
 		IOF.Close[*os.File],
-		IO.Map(FL.GetName),
+		IO.Map((*os.File).Name),
 		IOE.FromIO[error, string],
 		IOE.Chain(Remove),
 	)