Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on valid server object #217

Closed
mewalig opened this issue Dec 20, 2020 · 4 comments
Closed

Warning on valid server object #217

mewalig opened this issue Dec 20, 2020 · 4 comments
Assignees
Labels
spectral Waiting for fix to be released in Spectral

Comments

@mewalig
Copy link

mewalig commented Dec 20, 2020

Validating the following yields the following warning: Server URL should not have a trailing slash.

{
  "openapi": "3.0.3",
  "info": {
    "version": "1.0.0",
    "title": "test"
  },
  "servers": [
    {
      "url": "/"
    }
  ],
  "servers": [
    {
      "url": "/"
    }
  ],
  "description": "test",
  "components": {},
  "paths": {}
}

However, per https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#oasDocument:

which states:

the default value would be a Server Object with a url value of /

a server object with a url value of / should be acceptable

@mkistler mkistler self-assigned this Dec 27, 2020
@mkistler
Copy link
Contributor

Fix submitted to upstream Spectral project:

stoplightio/spectral#1427

@jorge-ibm
Copy link
Contributor

@mkistler looks like your upstream PR was merged and released. Can we close this issue ?

@mkistler
Copy link
Contributor

mkistler commented Jan 6, 2021

To truly call this done, we probably want to update our Spectral dependency to ensure the fix is pulled in. But I have a couple of other Spectral PRs open that I hope will be merged soon, so lets hold off for a few days and maybe get them all at once.

@dpopp07 dpopp07 added the spectral Waiting for fix to be released in Spectral label Feb 24, 2021
@barrett-schonefeld
Copy link
Contributor

Updated our Spectral dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spectral Waiting for fix to be released in Spectral
Projects
None yet
Development

No branches or pull requests

5 participants