fix(ruleset): Allow single trailing slash for oas3 server url #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
reviewed
Dec 28, 2020
Co-authored-by: Jakub Rożek <jakub@rozek.tech>
P0lip
approved these changes
Dec 29, 2020
|
Thanks again! |
P0lip
added a commit
that referenced
this pull request
Jan 4, 2021
* fix(ruleset): Allow single trailing slash for oas3 server url * Apply suggestions from code review Co-authored-by: Jakub Rożek <jakub@rozek.tech> Co-authored-by: Jakub Rożek <jakub@rozek.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small modification to the
oas3-server-trailing-slashrule to allow the url value to be a single slash.According to the description of the
serversfield of an OpenAPI object in the OpenAPI specification:Since the default value for the
urlis a single slash (/), this should be considered a valid value and not generate a warning message.Checklist
Does this PR introduce a breaking change?