-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split files do not use ligature layout feature #438
Comments
cc @abbeyhrt |
Strange that the font subsetter has automatically stripped the liga feature. Will investigate. |
Current split fonts in this repository only contain a We can generate new subsets where all those features are preserved. But then these fonts will become approx. 4 KB larger in size for the Latin1 woff files. What do you prefer: preserve all features? Or only preserve |
Here is a comparison: Current Latin1 split fonts in woff format (only containing
New Latin1 split fonts in woff format (containing all features)
|
Looking forward to hearing what you prefer @tay1orjones |
@BoldMonday Sorry for the delayed response, I ran this by the team and I think it's best to preserve all features for visual/brand consistency. |
@BoldMonday The |
@mjabbink @BoldMonday I spoke with @vpicone about this today and he brought up a good point that we likely want the available features to all be there and the same as what's available via the complete files. Also to have the same available features turned on by default. Reason being that in many cases the complete files are used as a fallback to the split files on the web. We wouldn't want the experience to change between split vs complete fallback. |
@BoldMonday Could you also add myself and two other members of the Carbon team to the email distribution list for notifying when updates have been published? Moving forward we're going to be helping @vpicone with releases. |
@tay1orjones Understood. We will generate new subsets with all features included and let you guys know by email when they're uploaded. You can expect them by tomorrow. |
New subsets have been uploaded. Please check your mail. |
Makes sense and would prefer that but I thought the goal was smaller file sizes. If that requirement goes away then all features are best for sure. |
I suggest to try the new subsets with all features. It’s been close to five years now since we introduced split fonts. In terms of web technology that’s a long time and things have improved significantly for most users, including bandwidth. |
Surfaced in carbon-design-system/carbon#11175
Split files do not have the layout features turned on enabling ligatures. The unicode character is included, but the layout feature is off so
fi
doesn't automatically get replaced with the ligature.This was noticed by @mjabbink when we updated Carbon to no longer use Google Fonts and instead provide the option to use assets directly from
@ibm/plex
or the IBM Akamai CDN (carbon-design-system/carbon#11002, carbon-design-system/carbon#11070)I'm not sure what version Google Fonts is using currently, but I assume it's an older one which would point to the current version being when this was introduced.
@BoldMonday We're assuming these just need re-exported with the feature turned on and a new minor/patch version published, but curious on your thoughts.
The text was updated successfully, but these errors were encountered: