-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@ibm/plex): Update plex dependency to use new packages #17025
feat(@ibm/plex): Update plex dependency to use new packages #17025
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
One thing to verify here is the ligature fixes from #11175 IBM/plex#438 are coming through. The storybook doesn't turn on the This should be fixed by this PR where we consume the new packages that contain these updates to the font files. I know this is still in draft, but right now I don't see the ligatures in the deploy preview. |
@tay1orjones it seems like a component-level issue for some reason. I will take a deeper look. I see the ligatures when just putting text outside of the notification Edit: It seems to be caused due to the |
@tw15egan wow, yeah it's part of the current css-fonts-3 spec and the working draft css-fonts-4 spec
Can we get around it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
efd08bc
Updates
@carbon/styles
to use individual@ibm/plex-${font-style}
packages rather than importing all from@ibm/plex
Changelog
New
@ibm/plex
familiesfont-feature-settings: 'liga' 1;
added to_reset.scss
to ensure ligatures render even withletter-spacing
set$package-name
field added to font src resolverChanged
url
field in font src resolver to use new package name formatRemoved
.woff
, so they have been removed from the individual font formatsTesting / Reviewing
Ensure the fonts are loaded correctly, either using the Akamai CDN or not. Ensure the
fi
ligature renders properly.