-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed to @use instead of @import #506
Conversation
Signed-off-by: Mary Ann <maryannjose129@gmail.com>
Deploy preview created: Built with commit: b5f34aa7792d424dab56e976dfa5f2ec6485f2a7 |
@tay1orjones could you check this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for making this update! Can you confirm this works for you? Maybe through an example stackblitz or something similar?
README.md
Outdated
$font-prefix: './custom/path/to/font/files'; | ||
@import 'node_modules/@ibm/plex/scss/ibm-plex.scss'; | ||
@use 'node_modules/@ibm/plex/scss/ibm-plex.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will work because @use
declarations are required to be the first thing in the file. Defining the $font-prefix
variable first will have no impact on the path provided to ibm-plex.scss
.
We may need to reconfigure how the scss is generated to support sass module configuration using with
@use 'node_modules/@ibm/plex/scss/ibm-plex.scss' with (
$font-prefix: './custom/path/to/font/files';
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I don't think the above will work with the way the scss is structured right now
This is outlined in #370, but the entire repo needs to be updated so the output uses |
Related: #309