Centralize and unify getSubset error checking

The fix in #523 did not cover all cases, as found by subsequent go-fuzz runs.
IBM · Aug 27, 2015 · 900e4f4 · 900e4f4
1 parent 6902717
commit 900e4f4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/fetch_response.go b/fetch_response.go
@@ -22,9 +22,6 @@ func (pr *FetchResponseBlock) decode(pd packetDecoder) (err error) {
 	if err != nil {
 		return err
 	}
-	if msgSetSize < 0 {
-		return PacketDecodingError{"invalid message set size"}
-	}
 
 	msgSetDecoder, err := pd.getSubset(int(msgSetSize))
 	if err != nil {

diff --git a/produce_request.go b/produce_request.go
@@ -90,9 +90,6 @@ func (p *ProduceRequest) decode(pd packetDecoder) error {
 			if err != nil {
 				return err
 			}
-			if messageSetSize == 0 {
-				continue
-			}
 			msgSetDecoder, err := pd.getSubset(int(messageSetSize))
 			if err != nil {
 				return err

diff --git a/real_decoder.go b/real_decoder.go
@@ -188,7 +188,9 @@ func (rd *realDecoder) remaining() int {
 }
 
 func (rd *realDecoder) getSubset(length int) (packetDecoder, error) {
-	if length > rd.remaining() {
+	if length < 0 {
+		return nil, PacketDecodingError{"invalid subset size"}
+	} else if length > rd.remaining() {
 		rd.off = len(rd.raw)
 		return nil, ErrInsufficientData
 	}