We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new TestDeleteOffsetsResponse looks like it can fail periodically due to a timing issue:
TestDeleteOffsetsResponse
% go test -run 'TestDeleteOffsetsResponse' -v -count=10 === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse request_test.go:96: Encoding no error failed got [0 0 0 0 0 0 0 0 0 1 0 3 98 97 114 0 0 0 2 0 0 0 7 0 0 0 0 0 6 0 0] want [0 0 0 0 0 0 0 0 0 1 0 3 98 97 114 0 0 0 2 0 0 0 6 0 0 0 0 0 7 0 0] --- FAIL: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) === RUN TestDeleteOffsetsResponse --- PASS: TestDeleteOffsetsResponse (0.00s) FAIL exit status 1 FAIL github.com/Shopify/sarama 0.361s
Needs investigating if we can make it more robust.
cc @faillefer
The text was updated successfully, but these errors were encountered:
Ah it's the randomised ordering of the map of partitions in the response
Sorry, something went wrong.
@dnwe Maybe the best correction is to sort by partition when encoding the response. So the result will always be the same. I can provide a fix
[IBM#2012] Sort partitions when encoding DeleteOffsetResponse
f05103e
6d470cc
Successfully merging a pull request may close this issue.
The new
TestDeleteOffsetsResponse
looks like it can fail periodically due to a timing issue:Needs investigating if we can make it more robust.
cc @faillefer
The text was updated successfully, but these errors were encountered: