add Describe/Create/DeleteAcls #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
reviewed
Jan 17, 2018
| return nil | ||
| } | ||
|
|
||
| type ResourceAcls struct { |
There was a problem hiding this comment.
I'm not sure why this is in the general file, it seems specific to the one request type?
|
One comment but it makes basically no difference. Thanks for your work on this and sorry it's taken me so long to get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing the
AdminClientrequest-response party withDescribe/Create/DeleteAcls.These share some common stuff so easier to PR them together.