Add support for DeleteGroups #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussellLuo
force-pushed
the
add-support-for-delete-groups
branch
from
2ca6a9e
to
6e84d2f
Compare
RussellLuo
force-pushed
the
add-support-for-delete-groups
branch
from
6e84d2f
to
0f1c3e9
Compare
eapache
reviewed
May 3, 2018
delete_groups_response.go
Outdated
| package sarama | ||
|
|
||
| type DeleteGroupsResponse struct { | ||
| ThrottleTimeMs int32 |
There was a problem hiding this comment.
For time fields we prefer to expose them as native go types, see e.g. https://github.com/Shopify/sarama/blob/0f333e6f2449e00440f7a53d3d2f006d702abe23/end_txn_response.go#L8
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1095.