fix: correct the error handling in client.InitProducerID() #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. |
crivera-fastly
force-pushed
the
fix-init-producer-id
branch
from
d759d7c to
af35301
Compare
crivera-fastly
force-pushed
the
fix-init-producer-id
branch
from
af35301 to
5cd020c
Compare
err was shadowed in InitProducerID() so it would never return a non-nil error. It now returns ErrOutOfBrokers if there aren't any registered brokers. If there are registered brokers and the broker calls fail then it returns the last encoutered error. This was causing a panic in newTransactionManager() with idempotent production enabled because nil, nil was being returned if the brokers were unavailable.
bai
force-pushed
the
fix-init-producer-id
branch
from
5cd020c to
193bd0f
Compare
|
I rebased this branch off of latest master. |
dnwe
approved these changes
Sep 13, 2021
dnwe
changed the title
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
err was shadowed in InitProducerID() so it would never return a non-nil
error. It now returns ErrOutOfBrokers if there aren't any registered brokers.
If there are registered brokers and the broker calls fail then it returns
the last encoutered error.
This was causing a panic in newTransactionManager() with idempotent
production enabled because nil, nil was being returned if the brokers were
unavailable.