Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add counter metrics for consumer group join/sync and their failures #2003

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

gdm85
Copy link
Contributor

@gdm85 gdm85 commented Aug 31, 2021

This PR adds 4 new metrics:

  • consumer-group-join-total-<GroupID>
  • consumer-group-join-failed-<GroupID>
  • consumer-group-sync-total-<GroupID>
  • consumer-group-sync-failed-<GroupID>

It should be useful when troubleshooting ongoing network issues.

@gdm85 gdm85 requested a review from bai as a code owner August 31, 2021 15:13
@ghost ghost added the cla-needed label Aug 31, 2021
@gdm85
Copy link
Contributor Author

gdm85 commented Aug 31, 2021

I have submitted the CLA (minus address), but I do not have rights to restart the GitHub Action.

@ghost ghost removed the cla-needed label Aug 31, 2021
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. The changes look good and I agree the client-side metrics would be useful. I've re-run the CLA check and also approved the GitHub actions

@bai
Copy link
Contributor

bai commented Sep 7, 2021

Thanks for your contribution! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants