Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose IncrementalAlterConfigs API in admin.go #2088

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

fengyinqiao
Copy link
Contributor

For #2083

@fengyinqiao fengyinqiao requested a review from bai as a code owner December 11, 2021 10:38
@ghost ghost added the cla-needed label Dec 11, 2021
@fengyinqiao
Copy link
Contributor Author

@dnwe Could you please help to deal with this PR? @bai seems to be busy with something recently.

@dnwe
Copy link
Collaborator

dnwe commented Dec 15, 2021

Thanks @fengyinqiao — these changes look reasonable to me, a good extension to expose the functionality added under #1966 — thanks for doing this PR

Please can you check on the CLA? Have you signed it with an email address that matches your GitHub username?

@fengyinqiao
Copy link
Contributor Author

@dnwe I didn't expect you to reply so quickly. Thank you so much!!! And I have signed the CLA, but why is it still a problem?How can I re-run the CLA check?

@dnwe
Copy link
Collaborator

dnwe commented Dec 15, 2021

@fengyinqiao I have re-run it, I think the problem is that your author email address in the commit is fengyinqiao@corp.netease.com but that email address doesn’t seem to be associated with your GitHub account so it’s not getting tracked

@fengyinqiao
Copy link
Contributor Author

@dnwe Sorry, that's my company email address for work. I didn't notice that... I can't use this email address to sign again, because my Github user name has already been signed, may I ask how to solve it?

@dnwe
Copy link
Collaborator

dnwe commented Dec 15, 2021

@fengyinqiao you can either add that email address as another contact address on this account, or you can “git commit —amend —reset-author” after changing your local git config to an email address that matches this GH account and then force push to your PR branch

@fengyinqiao
Copy link
Contributor Author

fengyinqiao commented Dec 15, 2021

@dnwe Sorry, that's my company email address for work. I didn't notice that... I can't use this email address to sign again, because my Github user name has already been signed, may I ask how to solve it?

@dnwe I have already added this email address to my GitHub account =_=, could you please run it again?

@ghost ghost removed the cla-needed label Dec 15, 2021
@dnwe
Copy link
Collaborator

dnwe commented Dec 15, 2021

Yep that’s passing now 🎉

@fengyinqiao
Copy link
Contributor Author

@dnwe Once again, I would like to express my sincere thanks to you, for your so so so quick reply 🎉🎉🎉

@fengyinqiao
Copy link
Contributor Author

@dnwe May I ask if this PR can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants