Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure heartbeats only stop after cleanup #2110

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Jan 12, 2022

Sarama would immediately stop heartbeating on rebalance. If the session teardown took longer than the session timeout, it would get evicted from the group.

This can be fixed by ensuring that heartbeats only stop after the session has completed its cleanup process.

Contributes-to: #1608

Sarama would immediately stop heartbeating on rebalance. If the session
teardown took longer than the session timeout, it would get evicted from
the group.

This can be fixed by ensuring that heartbeats only stop _after_ the
session has completed its cleanup process.

Contributes-to: #1608
@dnwe dnwe requested a review from bai as a code owner January 12, 2022 15:05
@ghost ghost added the cla-needed label Jan 12, 2022
@dnwe
Copy link
Collaborator Author

dnwe commented Jan 12, 2022

@pavius similarly, I extracted this change out of your original issue and fork so we can test and review it in isolation — thanks for your work on this, please could you sign the CLA?

@bai
Copy link
Contributor

bai commented Jan 21, 2022

@pavius 👋🏼 Friendly bump 🙏🏼 We're about to cut a new release - do you think you could sign CLA to unblock us? I'd appreciate it so much. ❤️

@pavius
Copy link
Contributor

pavius commented Jan 21, 2022

Signed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants