Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isValidVersion to protocol types #2538

Merged
merged 8 commits into from
Aug 3, 2023
Merged

feat: add isValidVersion to protocol types #2538

merged 8 commits into from
Aug 3, 2023

Commits on Aug 2, 2023

  1. feat(proto): add isValidVersion to protocol types 

    The intention here is that we can check that a request version value is
supported by the protocol encoder/decoder before sending it

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3dfbf99 View commit details
    Browse the repository at this point in the history

  2. fix(proto): use DescribeLogDirsRequest v1 

    This is identical to v0 but can used from broker 2.0.0.0 onwards

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    fa37d61 View commit details
    Browse the repository at this point in the history

  3. fix(proto): ensure req+resp requiredVersion match 

    Testing uncovered a few mismatches between the requiredVersion
implementation in the request and response for these types

Also fix wrong key() in alter_configs_response!

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    40fa609 View commit details
    Browse the repository at this point in the history

  4. fix(proto): extend txn types for identical versions 

    Co-authored-by: Mark Hindess <hindessm@users.noreply.github.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe @hindessm
    dnwe and hindessm committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c240c67 View commit details
    Browse the repository at this point in the history

  5. fix(proto): correct consumer metadata shim 

    This is really just proxying to
FindCoordinatorRequest/FindCoordinatorResponse, but for now just copy in
the same isValidVersion/requiredVersion code and ensure we're passing
Version to and from it correctly.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3b82606 View commit details
    Browse the repository at this point in the history

  6. fix(admin): remove group member needs >= 2.4.0 

    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ee2872c View commit details
    Browse the repository at this point in the history

  7. feat(proto): add test around supported versions 

    Initially seeded with only the protocol versions required for Kafka
v1.1, check we've implemented the expected versions and they pass the
isValidVersion and the requiredVersion checks as expected.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b8cc2b1 View commit details
    Browse the repository at this point in the history

  8. fix(proto): use DeleteRecordsRequest v1 

    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a9126ad View commit details
    Browse the repository at this point in the history