fix(proto): correct JoinGroup usage for wider version range #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
hindessm
reviewed
Aug 3, 2023
| if c.config.Version.IsAtLeast(V2_0_0_0) { | ||
| req.Version = 3 | ||
| } | ||
| // XXX: protocol states "Starting from version 4, the client needs to issue a |
There was a problem hiding this comment.
the if below this comment sets req.Version = 5 so this must work or already be broken?
There was a problem hiding this comment.
Yes, although I’ve not personally tested the V5 and static membership stuff so I didn’t want to introduce any breakage until I’d tested it
hindessm
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes-to: #2408