Fix offset_manager for Kafka 0.9.0.0 #585
Conversation
horkhe
force-pushed
the
maxim/offset_manager
branch
2 times, most recently
from
4c213c2 to
29f4ca6
Compare
| if _, err := offsetManager.ManagePartition("does_not_exist", 123); err != ErrUnknownTopicOrPartition { | ||
| t.Fatal("Expected ErrUnknownTopicOrPartition when starting a partition offset manager for a partition that does not exist, got:", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why did this have to be removed? Is it because the new group protocol is abstract, and potentially could work for other sources besides kafka partitions? (e.g. Kafka Connect). Or is there another reason?
There was a problem hiding this comment.
You no longer get back ErrUnknownTopicOrPartition, you get back ErrNoError with an offset of -1 (just like you do for topic/partitions that exist but haven't yet had an offset committed). I'm honestly not sure if this is a kafka bug, or an intended behaviour change.
There was a problem hiding this comment.
Yea, it is just not an error anymore. Whether it is a bug or behaviour change we cannot think of anything smarter than stop checking that.
There was a problem hiding this comment.
👍 Given the differences in behavior between Kafka versions, removing this assertion is probably best.
|
Nice find 👍 |
|
Very nice find on setting the generation to -1. |
|
I am having second thoughts about using |
|
👍 for |
horkhe
force-pushed
the
maxim/offset_manager
branch
from
29f4ca6 to
1e5cc31
Compare
|
Added the constant and squashed. |
Fix offset_manager for Kafka 0.9.0.0
Here is why the solution works.