waterfall plot y limits not working

[m-philipps]

It is not always possible to set the y limits of a waterfall plot using the y_limits argument, because
this condition:

pyPESTO/pypesto/visualize/misc.py

Line 173 in 2eb0d15

if ax.get_yscale() == 'log' and y_limits[0] <= 0.0:

needs to be fulfilled in order to reach this line:

pyPESTO/pypesto/visualize/misc.py

Line 189 in 2eb0d15

ax.set_ylim(y_limits)

[m-philipps]

Does it make sense to set the same y limits for the zoomed-in starts?

pyPESTO/pypesto/visualize/waterfall.py

Lines 170 to 173 in 2eb0d15

	if inset_axes is not None:
	inset_axes = handle_options(
	inset_axes, n_starts_to_zoom, refs, y_limits, offset_y
	)

I would suggest to choose the y limits automatically here, i.e. use y_limits=None in the call above

[dweindl]

It is not always possible to set the y limits of a waterfall plot using the y_limits argument, because

I'd say that's an identation bug at

pyPESTO/pypesto/visualize/misc.py

Lines 188 to 189 in 2eb0d15

	# set limits
	ax.set_ylim(y_limits)

Dedenting those lines solves the issue, right?

Does it make sense to set the same y limits for the zoomed-in starts?

Probably not. Letting matplotlib choose limits sounds plausible.