Fix for petab 0.2.x #1073
Merged
Fix for petab 0.2.x #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #1073 +/- ##
===========================================
- Coverage 88.16% 83.56% -4.61%
===========================================
Files 79 147 +68
Lines 5257 11395 +6138
===========================================
+ Hits 4635 9522 +4887
- Misses 622 1873 +1251
|
|
looking for volunteers to wrap this up |
Done |
dweindl
approved these changes
Jun 6, 2023
yannikschaelte
approved these changes
Jun 6, 2023
| @@ -73,7 +73,7 @@ jobs: | |||
| run: .github/workflows/install_deps.sh amici pysb | |||
|
|
|||
| - name: Run tests | |||
| timeout-minutes: 25 | |||
| timeout-minutes: 35 | |||
There was a problem hiding this comment.
if it takes that long out of a sudden, something should be wrong. was 15 not long ago
There was a problem hiding this comment.
The number of test cases increased:
- additional test cases
- running for both SBML and PySB models
dweindl
added a commit
that referenced
this pull request
Jun 19, 2023
Since #1073, we don't need an extra `PetabImporterPysb`, as anything PySB-specific is handled inside PEtab/AMICI.
dweindl
added a commit
that referenced
this pull request
Jun 20, 2023
Since #1073, we don't need an extra `PetabImporterPysb`, as anything PySB-specific is handled inside PEtab/AMICI.
This was referenced Jun 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.