Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in bound checking. #1081

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Conversation

PaulJonasJost
Copy link
Collaborator

Closes #1080.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #1081 (3545e38) into develop (f6730f8) will decrease coverage by 1.24%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #1081      +/-   ##
===========================================
- Coverage    84.81%   83.57%   -1.24%     
===========================================
  Files          146      146              
  Lines        11392    11392              
===========================================
- Hits          9662     9521     -141     
- Misses        1730     1871     +141     
Impacted Files Coverage Δ
pypesto/problem/base.py 92.10% <100.00%> (ø)

... and 14 files with indirect coverage changes

dweindl and others added 2 commits June 20, 2023 14:33
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@dweindl dweindl mentioned this pull request Jun 22, 2023
@PaulJonasJost PaulJonasJost requested a review from a team as a code owner June 23, 2023 11:32
@yannikschaelte yannikschaelte merged commit 462481e into develop Jun 23, 2023
@yannikschaelte yannikschaelte deleted the fix_parameter_bounds_check branch June 23, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants