Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hierarchical parameter plot fix #1106

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Hierarchical parameter plot fix #1106

merged 6 commits into from
Aug 4, 2023

Commits on Jul 28, 2023

  1. Fix parameter plot 

    If, in any case (because some inner optimization failed, simulation failed, or some other reason) and there is a`optimize_result`dictionary in `result.optmize_result.list` which doesn't contain the `INNER_PARAMETERS` key and its item, the parameter plot would fail at line 381.

This is a fix to make it robust to this. If any of the `optimize_result` objects has a `INNER_PARAMETER` key, then the other ones will be filled with NaN values, and plotted.
    @Doresic
    Doresic committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2fde68e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Dilan review change 

    Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
    @Doresic @dilpath
    Doresic and dilpath authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    49b7d07 View commit details
    Browse the repository at this point in the history

  2. Update pypesto/visualize/parameters.py 

    Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
    @Doresic @dweindl
    Doresic and dweindl authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    747162d View commit details
    Browse the repository at this point in the history

  3. Add comments

    @Doresic
    Doresic committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4c44f31 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Add comment 

    Testing the quality check
    @Doresic
    Doresic committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    69d004f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix quality check error

    @Doresic
    Doresic committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    76de8a8 View commit details
    Browse the repository at this point in the history