-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ensembles from optimization endpoints #1130
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1130 +/- ##
===========================================
- Coverage 88.16% 84.38% -3.79%
===========================================
Files 79 148 +69
Lines 5257 11642 +6385
===========================================
+ Hits 4635 9824 +5189
- Misses 622 1818 +1196
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue of getting constant predictions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@PaulJonasJost is this an issue in |
If only the names of free parameters are taken https://github.com/ICB-DCM/pyPESTO/blob/main/pypesto/ensemble/ensemble.py#L663,
then maybe the same should be true for the parameter values