SacessOptimizer: avoid FileNotFoundError if run with ridiculously low… #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… walltime limit It was possible that SacessOptimizer would quit before even starting the first iteration if a tiny walltime limit is set. This led to a FileNotFoundError when trying to collect the temporary results. Fixed here by starting at least one iteration. Closes ICB-DCM#1172
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1177 +/- ##
===========================================
- Coverage 84.28% 82.91% -1.37%
===========================================
Files 148 148
Lines 11693 11693
===========================================
- Hits 9855 9695 -160
- Misses 1838 1998 +160 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… walltime limit
It was possible that SacessOptimizer would quit before even starting the first iteration if a tiny walltime limit is set. This led to a FileNotFoundError when trying to collect the temporary results. Fixed here by starting at least one iteration.
Closes #1172