-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: Don't run quality checks twice #1193
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1193 +/- ##
===========================================
- Coverage 84.26% 81.71% -2.56%
===========================================
Files 148 148
Lines 11724 11724
===========================================
- Hits 9879 9580 -299
- Misses 1845 2144 +299 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, never noticed that it was run twice.
GHA: Don't run quality checks twice
Already run here:
https://github.com/ICB-DCM/pyPESTO/blob/develop/.pre-commit-config.yaml#L62
Via:
https://github.com/ICB-DCM/pyPESTO/blob/develop/.github/workflows/ci.yml#L322C6-L322C6
Also cache
.tox/
.Don't run tox repeatedly and in parallel (Fixes Random quality test failures #1186)
1 min faster