SacessOptimizer: Fix passing parameters #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug during the cooperation step where best parameters wouldn't be shared correctly.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1201 +/- ##
===========================================
- Coverage 82.73% 81.41% -1.33%
===========================================
Files 148 148
Lines 11775 11782 +7
===========================================
- Hits 9742 9592 -150
- Misses 2033 2190 +157 ☔ View full report in Codecov by Sentry. |
…er vector is stored in local solutions and sent to the manager.
PaulJonasJost
approved these changes
Nov 21, 2023
Comment on lines
+531
to
540
| local_solution_x = optimizer_result.x[ | ||
| optimizer_result.free_indices | ||
| ] | ||
| local_solution_fx = optimizer_result.fval | ||
|
|
||
| self.local_solutions.append(local_solution_x) | ||
|
|
||
| self._maybe_update_global_best( | ||
| optimizer_result.x, optimizer_result.fval | ||
| local_solution_x, local_solution_fx | ||
| ) |
There was a problem hiding this comment.
Conceptually, why was this changed? what was not working here?
There was a problem hiding this comment.
OptimzerResult.free_indices was ignored, i.e. potentially nonsensical parameter were used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncManager.Array.