SacessOptimizer: Update worker settings #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dweindl
commented
Nov 20, 2023
dweindl
commented
- Most importantly fix default RefSet sizes (too big before)
- Add default settings for >10 workers
* Most importantly fix default RefSet sizes (too big before) * Add default settings for >10 workers
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1202 +/- ##
============================================
- Coverage 84.08% 63.43% -20.66%
============================================
Files 148 148
Lines 11775 11778 +3
============================================
- Hits 9901 7471 -2430
- Misses 1874 4307 +2433 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Nov 21, 2023
| min_dimrefset = 5 | ||
|
|
||
| def dim_refset(x): | ||
| return max(min_dimrefset, ceil((1 + sqrt(4 * dim * x)) / 2)) |
There was a problem hiding this comment.
Is this also based on the reference. Could not find the function MOD(ids...)
There was a problem hiding this comment.
Yes. The MOD is replaced by cycle at the end of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.